Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

@qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Nov 24, 2021

Proposed changes

This is the first step at integrating the observability changes into the project. This deploys the OTEL operator into its own namespace, and then instantiates a collector in the observability namespace.

The configuration for the collector is kept intentionally simple; by default the collector will listen for OTEL traffic on grpc and HTTP, and output that data to the stdout of the container. The output is summarized.

For additional configurations, please see the README in the observability directory.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Jason Schmidt added 3 commits November 19, 2021 12:41
feat: add observability logic
feat: add observability configurations and readme
fix: re-enable errexit; mistakenly disabled on previous commit.
@qdzlug qdzlug requested a review from dekobon November 24, 2021 17:34
feat: create tracing config map and update yaml
Copy link
Collaborator

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

feat: updates to README.md for observability
@qdzlug qdzlug merged commit b960c5b into nginxinc:master Nov 29, 2021
@qdzlug qdzlug deleted the otel branch December 3, 2021 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants