Bulk delete namespaces in reconfiguration nfr test#3402
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
+ Coverage 86.75% 86.78% +0.03%
==========================================
Files 129 129
Lines 14928 14928
Branches 62 62
==========================================
+ Hits 12951 12956 +5
+ Misses 1826 1822 -4
+ Partials 151 150 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjberman
reviewed
May 27, 2025
bjee19
commented
May 27, 2025
sjberman
approved these changes
May 27, 2025
134e169 to
8ea5e0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bulk delete namespaces function to use in reconfiguration nfr test to improve performance.
Problem: The reconfiguration nfr test takes a very long time to run because we are deleting namespaces individually, we could save a lot of time by bulk deleting them.
Solution: Add a function which deletes multiple namespaces at a single time.
Testing: Ran the nfr test and confirms it still works.
Closes #2376
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.