Skip to content

Conversation

@lucacome
Copy link
Contributor

@lucacome lucacome commented May 17, 2024

Proposed changes

Problem: Generation is slow and throws a bunch of warnings.

Solution: Use go:generate once per package as suggested in https://github.com/maxbrunsfeld/counterfeiter#step-2b---add-counterfeitergenerate-directives

Testing: I removed all the generated files and they are re-generated correctly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner May 17, 2024 19:49
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 17, 2024
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucacome lucacome merged commit 9212c4b into nginx:main May 20, 2024
@sjberman sjberman mentioned this pull request May 20, 2024
6 tasks
@lucacome lucacome deleted the chore/generation branch May 21, 2024 01:13
@lucacome lucacome self-assigned this May 23, 2024
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants