Only update a resource's status if it has changed #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
kate-osborn
changed the title
pleshakov
reviewed
Oct 18, 2023
bjee19
requested changes
Oct 18, 2023
kate-osborn
force-pushed
the
fix/status-update
branch
from
ae9b8ad to
cfae9ee
Compare
bjee19
approved these changes
Oct 19, 2023
pleshakov
approved these changes
Oct 19, 2023
kate-osborn
force-pushed
the
fix/status-update
branch
from
cfae9ee to
20935f9
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: NGF updates the status of resources even when the status has not changed. When there are a large number of HTTPRoutes this can significantly decrease processing time. Solution: Modify the status updater to only update status when it has changed. Testing: Re-ran the scale tests. The scale test performance numbers significantly improved with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NGF updates the status of resources even when the status has not changed.
When there are a large number of HTTPRoutes this can significantly decrease processing time.
Solution: Modify the status updater to only update status when it has changed.
Testing: Added unit tests, manually tested changes, and re-ran the scale tests.
The scale test performance numbers significantly improved with this change.
Closes #1013
Checklist
Before creating a PR, run through this checklist and mark each as complete.