Skip to content

Conversation

@haywoodsh
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Signed-off-by: Haywood Shannon <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Nov 13, 2024
…ector

Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@haywoodsh haywoodsh force-pushed the feat/vsr-route-selector branch from 39bdde4 to d03be9f Compare November 13, 2024 17:06
@haywoodsh
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 18, 2024
@github-actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Feb 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Mar 6, 2025
@github-project-automation github-project-automation bot moved this from Todo ☑ to Done 🚀 in NGINX Ingress Controller Mar 6, 2025
@haywoodsh haywoodsh reopened this Dec 2, 2025
@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label Dec 2, 2025
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 55.91398% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.73%. Comparing base (ffae94c) to head (5046e8a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/configuration.go 70.49% 15 Missing and 3 partials ⚠️
internal/configs/virtualserver.go 5.88% 15 Missing and 1 partial ⚠️
internal/k8s/controller.go 70.00% 3 Missing ⚠️
pkg/apis/configuration/validation/virtualserver.go 33.33% 1 Missing and 1 partial ⚠️
internal/k8s/global_configuration.go 0.00% 1 Missing ⚠️
internal/k8s/handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6803      +/-   ##
==========================================
- Coverage   53.81%   53.73%   -0.08%     
==========================================
  Files          91       91              
  Lines       18557    18614      +57     
==========================================
+ Hits         9986    10002      +16     
- Misses       8046     8081      +35     
- Partials      525      531       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@github-actions github-actions bot removed the stale Pull requests/issues with no activity label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

3 participants