-
Notifications
You must be signed in to change notification settings - Fork 101
[Dev] Add a run directory when developing locally #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
+ Coverage 86.27% 86.39% +0.11%
==========================================
Files 102 102
Lines 12622 12622
==========================================
+ Hits 10890 10905 +15
+ Misses 1253 1236 -17
- Partials 479 481 +2 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Proposed changes
This change modifies the Makefile to create a
build/rundirectory when running themake devtarget, with the goal of making local development of the agent a little easier by keeping all of our runtime files in an easy to access location.This directory must be added to the
allowed_directoriesinnginx-agent.confbefore runningmake dev.This directory will contain several files which we create at runtime:

Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)