Skip to content

Replace yants with the module system #991

Merged
fricklerhandwerk merged 2 commits intongi-nix:mainfrom
eljamm:migrate/models/switch-typing
May 15, 2025
Merged

Replace yants with the module system #991
fricklerhandwerk merged 2 commits intongi-nix:mainfrom
eljamm:migrate/models/switch-typing

Conversation

@eljamm
Copy link
Contributor

@eljamm eljamm commented May 2, 2025

Part of #949
Depends on #990

@eljamm eljamm marked this pull request as draft May 5, 2025 08:31
@eljamm eljamm force-pushed the migrate/models/switch-typing branch from 67958f7 to 8263cb0 Compare May 5, 2025 09:08
@eljamm eljamm marked this pull request as ready for review May 5, 2025 09:13
@eljamm eljamm marked this pull request as draft May 5, 2025 16:55
@eljamm
Copy link
Contributor Author

eljamm commented May 5, 2025

Apparently, tests are not being passed because of this. Will investigate.

@eljamm eljamm force-pushed the migrate/models/switch-typing branch from 9e8bd90 to 50bcc4e Compare May 5, 2025 17:03
@eljamm
Copy link
Contributor Author

eljamm commented May 5, 2025

Apparently, tests are not being passed because of this. Will investigate.

The projects were not being built correctly. Fixed.

@eljamm eljamm marked this pull request as ready for review May 5, 2025 17:05
@eljamm eljamm mentioned this pull request May 6, 2025
The template check was a bit of a hack and didn't work that well,
anyways. We can implement something similar to this in the future in
`projects/default.nix` if we want to, but for now the template will be
indirectly checked through new project entries.
@fricklerhandwerk fricklerhandwerk force-pushed the migrate/models/switch-typing branch 2 times, most recently from 9e93d6a to dbb265f Compare May 15, 2025 20:14
@fricklerhandwerk fricklerhandwerk force-pushed the migrate/models/switch-typing branch from dbb265f to fe4461f Compare May 15, 2025 20:15
@fricklerhandwerk fricklerhandwerk merged commit cd54cfc into ngi-nix:main May 15, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this to Done in Nix@NGI May 15, 2025
@fricklerhandwerk
Copy link
Contributor

@eljamm I sliced it somewhat differently so the diff shows the swap more clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants