-
Notifications
You must be signed in to change notification settings - Fork 249
Allow task.ext.prefix2 in modules linting #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+10
−1
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2196f07
Allow task.ext.prefix2
SPPearce e7cc0c6
Update Changelog
SPPearce 6b39258
Only allow prefix2, and check prefix1 doesn't pass
SPPearce dc9808a
Implement Mahesh's comments
SPPearce 8eb4913
Add invalid keys into the test
SPPearce b7c639d
Merge remote-tracking branch 'origin/dev' into prefix2
SPPearce b0af01e
Merge in dev and fix Changelog
SPPearce 1660c42
[automated] Update CHANGELOG.md
nf-core-bot 8a653c3
Merge branch 'dev' into prefix2
SPPearce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1062,6 +1062,20 @@ def args99 = task.ext.args99 ?: '' | |
| ) | ||
| assert len(mock_lint.failed) == 0 | ||
|
|
||
| # ext.prefixN where N >= 2 should be valid | ||
| mock_lint.passed, mock_lint.failed = [], [] | ||
| check_script_section( | ||
| mock_lint, | ||
| [ | ||
| """ | ||
| def prefix2 = task.ext.prefix2 ?: '' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a test for
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a test for prefix1. |
||
| def prefix10 = task.ext.prefix10 ?: '' | ||
| def prefix99 = task.ext.prefix99 ?: '' | ||
| """ | ||
| ], | ||
| ) | ||
| assert len(mock_lint.failed) == 0 | ||
|
|
||
| # Check false positive matches, e.g. text.tokenize() | ||
| mock_lint.passed, mock_lint.failed = [], [] | ||
| check_script_section( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought only prefix2 would be allowed, not prefix3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment I just copied the args code and added prefix as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapped to just adding prefix2 directly to the allowed keys.