Skip to content

Switch to uv and prek on pipeline linting - #3942

Merged
dialvarezs merged 5 commits into
nf-core:devfrom
dialvarezs:modernize-pipeline-linting
Dec 11, 2025
Merged

Switch to uv and prek on pipeline linting#3942
dialvarezs merged 5 commits into
nf-core:devfrom
dialvarezs:modernize-pipeline-linting

Conversation

@dialvarezs

@dialvarezs dialvarezs commented Nov 30, 2025

Copy link
Copy Markdown
Member

This PR modernizes and speeds up pipeline linting by using uv and prek.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@dialvarezs
dialvarezs force-pushed the modernize-pipeline-linting branch from 91e3fd1 to 636d663 Compare November 30, 2025 13:04
@dialvarezs

Copy link
Copy Markdown
Member Author

Not sure why am I getting failed tests, this PR doesn't change any of the actual nextflow code.

@mashehu

mashehu commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

It is because we merged nf-core/modules#9333, which converted some modules to the new version topic syntax and unfortunately one of them was linted for the old syntax in the test. I am working on update of the test

Comment thread nf_core/pipeline-template/.github/workflows/linting.yml Outdated
@codecov

codecov Bot commented Dec 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (3d0c98d) to head (8758837).
⚠️ Report is 6 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dialvarezs and others added 2 commits December 11, 2025 07:36
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@dialvarezs
dialvarezs merged commit a70e6f2 into nf-core:dev Dec 11, 2025
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants