Skip to content

Fix ro crate in bump version #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirpedrol merged 3 commits into from
Dec 13, 2024
Merged

Fix ro crate in bump version #3354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
307d0d4
only bump ro-crate if it already exists
mashehu Dec 12, 2024
b1ebca0
Merge branch 'dev' into fix-ro-crate-in-bump-version
mirpedrol Dec 13, 2024
8c5855f
get max of 100 branch names
mirpedrol Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nf_core/pipelines/bump_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@ def bump_pipeline_version(pipeline_obj: Pipeline, new_version: str) -> None:
yaml_key=["template", "version"],
)

# update rocrate
ROCrate(pipeline_obj.wf_path).update_rocrate()
# update rocrate if ro-crate is present
if Path(pipeline_obj.wf_path, "ro-crate-metadata.json").exists():
ROCrate(pipeline_obj.wf_path).update_rocrate()


def bump_nextflow_version(pipeline_obj: Pipeline, new_version: str) -> None:
Expand Down
2 changes: 1 addition & 1 deletion nf_core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ def get_repo_releases_branches(pipeline, wfs):
raise AssertionError(f"Not able to find pipeline '{pipeline}'")

# Get branch information from github api - should be no need to check if the repo exists again
branch_response = gh_api.safe_get(f"https://api.github.com/repos/{pipeline}/branches")
branch_response = gh_api.safe_get(f"https://api.github.com/repos/{pipeline}/branches?per_page=100")
for branch in branch_response.json():
if (
branch["name"] != "TEMPLATE"
Expand Down
Loading