Skip to content

TEMPLATE: Keep pipeline name in version.yml file#3223

Merged
maxulysse merged 5 commits into
devfrom
maxulysse-patch-5
Oct 15, 2024
Merged

TEMPLATE: Keep pipeline name in version.yml file#3223
maxulysse merged 5 commits into
devfrom
maxulysse-patch-5

Conversation

@maxulysse
Copy link
Copy Markdown
Member

Why going for pipeline when we have shortname?

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Why going for pipeline when we have shortname?
Comment thread nf_core/pipeline-template/workflows/pipeline.nf Outdated
@maxulysse maxulysse changed the title Keep pipeline name in version.yml file TEMPLATE - Keep pipeline name in version.yml file Oct 14, 2024
@mashehu mashehu changed the title TEMPLATE - Keep pipeline name in version.yml file TEMPLATE: Keep pipeline name in version.yml file Oct 14, 2024
@mashehu
Copy link
Copy Markdown
Contributor

mashehu commented Oct 14, 2024

@nf-core-bot changelog

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (78c9228) to head (18cbf05).
Report is 7 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread nf_core/pipeline-template/workflows/pipeline.nf Outdated
Copy link
Copy Markdown
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@maxulysse maxulysse enabled auto-merge October 15, 2024 07:54
@maxulysse maxulysse merged commit f2252c5 into dev Oct 15, 2024
@maxulysse maxulysse deleted the maxulysse-patch-5 branch October 15, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants