Skip to content

TEMPLATE: Parallelize pipeline GHA tests over docker/conda/singularity#3214

Merged
maxulysse merged 17 commits into
devfrom
maxulysse-patch-6
Oct 11, 2024
Merged

TEMPLATE: Parallelize pipeline GHA tests over docker/conda/singularity#3214
maxulysse merged 17 commits into
devfrom
maxulysse-patch-6

Conversation

@maxulysse
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse
Copy link
Copy Markdown
Member Author

continue from #3149

@maxulysse
Copy link
Copy Markdown
Member Author

@nf-core-bot fix linting pretty please 🙏

Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (3b8cd7f) to head (3bd7105).
Report is 18 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
@maxulysse
Copy link
Copy Markdown
Member Author

we also need singularity and conda setup as well

@maxulysse
Copy link
Copy Markdown
Member Author

In usage already in nf-core/bamtofastq#96

Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
Comment thread nf_core/pipeline-template/.github/workflows/ci.yml
Comment on lines +73 to +80
- name: Set up Conda
if: matrix.profile == 'conda'
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test,singularity --outdir ./results
if: "{% raw %}${{ github.base_ref == 'master' }}{% endraw %}"
conda clean -a
conda install -n base conda-libmamba-solver
conda config --set solver libmamba
echo $(realpath $CONDA)/condabin >> $GITHUB_PATH
echo $(realpath python) >> $GITHUB_PATH
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these shouldn't be needed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy pasted from modules

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so which part should I remove there?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
@mirpedrol
Copy link
Copy Markdown
Member

Linting is failing because of the location of some of the {% raw %} and {% endraw %}, you can use less of them, let me know if I should give it a try so that I don't interfere with your commits to the same branch

Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
@maxulysse maxulysse changed the title Parallelize pipeline GHA tests over docker/conda/singularity TEMPLATE: Parallelize pipeline GHA tests over docker/conda/singularity Oct 10, 2024
@maxulysse
Copy link
Copy Markdown
Member Author

What's the code for the CHANGELOG?

Comment thread nf_core/pipeline-template/.github/workflows/ci.yml Outdated
@maxulysse maxulysse merged commit 88dc61c into dev Oct 11, 2024
@maxulysse maxulysse deleted the maxulysse-patch-6 branch October 11, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants