-
Notifications
You must be signed in to change notification settings - Fork 453
Add low-pass bam/vcf and genetic map #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JoseEspinosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
hmm, this broke some tests that relied on the old file names, e.g. https://github.com/nf-core/modules/actions/runs/19709033762/job/56464494808?pr=9333#step:6:848 |
|
I'm currently updating them |
|
I think the easier move would be to add the the files without removing old files. Or was there something wrong with them? |
|
The aim was to avoid to have the same file with two or only one chromosome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LouisLeNezet , why was this deleted?
This has broken sarek tests:
https://github.com/nf-core/sarek/actions/runs/19706542568/job/56455675487?pr=2060#step:4:1381
as well as presumably two modules (cnvnator/cnvnator and cnvnator/convert2vcf)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just add the old files back (with a fixed map)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry. That it broke sarek pipeline.
I will add back the chr22 only files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the two other modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! don't want to rewrite all tests for the upcoming release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also add the vcf files back? That broke a subworkflow test https://github.com/nf-core/modules/actions/runs/19733276765/job/56539345421?pr=9333#step:6:1304
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #1803
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This PR add bam and vcf file for two individuals on two chromosomes to simulate low-pass data.
Genetic map in various format for the different imputation tools are also added as well as the reference panel for the two chromosomes.