Dev -> Master for 3.20.0 #1593
Merged
Dev -> Master for 3.20.0 #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back to dev + nft-utils 0.0.4
Update awsfulltest.yml to restore aligner-wise output
Add sentieon star
Bump version to 3.20.0 ahead of release
|
maxulysse
approved these changes
Aug 15, 2025
11 tasks
Exclude star rsem pca from snaps
…om_snaps Exclude unstable star_rsem clusterings from snaps
SPPearce
approved these changes
Aug 15, 2025
| author: "Harshil Patel, Phil Ewels, Rickard Hammar\xE9n" | ||
| description: RNA sequencing analysis pipeline for gene/isoform quantification and | ||
| extensive quality control. | ||
| author: "Harshil Patel, Phil Ewels, Rickard Hammarén" |
Contributor
There was a problem hiding this comment.
Just to nitpick, at what point does this pipeline become not 'authored' by these three people?
Member
There was a problem hiding this comment.
For me, these are the historic authors.
The contributors list in the manifest in the nextflow.config, reflects everyone.
And the author key has even been removed.
Also this author list has been replaced by the nf-core/rnaseq team in the LICENSE file.
For me, this list in this file, is just a remnant and is due to disappear in future TEMPLATE update.
@mirpedrol could probably confirm if I'm right or not
Member
There was a problem hiding this comment.
But the Credits section of the README could get an update, as I believe @pinin4fjords to be the true maintainer of this pipeline.
As I'm now in charge of this release since Jon is away, I'll let it slide and we'll make sure to update this later.
Thanks for nitpicking.
I do believe it's important to properly credit people for their work.
Member
There was a problem hiding this comment.
This value should contain the same names that are listed in contributors with the contribution "author", in the manifest of nextflow.config. In fact, when we generate the pipeline from the template we use this to populate the contributors field.
If these names in particular should be listed as authors is a different discussion. To me, authors are the original authors, and can include others if they have contributed significantly (for example on a pipeline rewrite, etc.). But maybe we could discuss this within core-team or maintainers.
Contributor
There was a problem hiding this comment.
Yeah, I think this could do with a discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).