Skip to content

Remove reference to unused "skip_sample_count" value in email templates #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinin4fjords merged 3 commits into from
Dec 17, 2024
Merged

Remove reference to unused "skip_sample_count" value in email templates #1459

pinin4fjords merged 3 commits into from
Dec 17, 2024

Conversation

@robsyme
Copy link
Contributor

@robsyme robsyme commented Nov 29, 2024

The email templates attempt to resolve a variable skip_sample_count but this variable is never created or referenced anywhere else in the workflow.

@github-actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dd26536

+| ✅ 188 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-17 17:48:37

@nf-core-bot
Copy link
Member

nf-core-bot commented Dec 17, 2024

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@pinin4fjords pinin4fjords merged commit 246b9dd into dev Dec 17, 2024
28 checks passed
@pinin4fjords pinin4fjords deleted the remove-unused-params-in-email-template branch February 11, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robsyme @nf-core-bot @pinin4fjords