Skip to content

Fix invalid named parameter syntax #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinin4fjords merged 5 commits into from
Sep 20, 2024
Merged

Fix invalid named parameter syntax #1376

pinin4fjords merged 5 commits into from
Sep 20, 2024

Conversation

@pditommaso
Copy link
Contributor

@pditommaso pditommaso commented Sep 6, 2024 •
edited
Loading

The excellent secret lang plugin already discovered some invalid syntax. Patching it

@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 82c833d

+| ✅ 174 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-20 14:54:08

@ewels ewels changed the base branch from master to dev September 6, 2024 15:15
@ewels
Copy link
Member

ewels commented Sep 6, 2024

@nf-core-bot changelog

@pinin4fjords
Copy link
Member

pinin4fjords commented Sep 10, 2024

Thanks @pditommaso !

maxulysse
maxulysse reviewed Sep 20, 2024
View reviewed changes
@pinin4fjords pinin4fjords merged commit fadc4ea into dev Sep 20, 2024
@maxulysse maxulysse deleted the pditommaso-patch-1 branch September 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pditommaso @ewels @pinin4fjords @maxulysse