Skip to content

standalone-installer-unix: Use ~/.profile when the default shell is sh#321

Merged
tsibley merged 1 commit into
masterfrom
trs/standalone-installers/sh-profile
Oct 11, 2023
Merged

standalone-installer-unix: Use ~/.profile when the default shell is sh#321
tsibley merged 1 commit into
masterfrom
trs/standalone-installers/sh-profile

Conversation

@tsibley
Copy link
Copy Markdown
Contributor

@tsibley tsibley commented Oct 10, 2023

We were suggesting nonsense (~/.shrc) due to our final fallback/guess. Instead, handle sh specifically and correctly.

Resolves #319.

Checklist

  • Manual test with default shell of /bin/sh works
  • Checks pass

@tsibley
Copy link
Copy Markdown
Contributor Author

tsibley commented Oct 10, 2023

CI will probably fail due to #320

We were suggesting nonsense (~/.shrc) due to our final fallback/guess.
Instead, handle sh specifically and correctly.

Resolves <#319>.
@tsibley tsibley force-pushed the trs/standalone-installers/sh-profile branch from 913b79b to c6e72d8 Compare October 11, 2023 00:27
@tsibley tsibley requested a review from a team October 11, 2023 00:28
@tsibley tsibley merged commit b7b61e0 into master Oct 11, 2023
@tsibley tsibley deleted the trs/standalone-installers/sh-profile branch October 11, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid ~/.shrc file named in standalone installer instructions

2 participants