[batch] Improvements when attaching to completed jobs #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joverlee521
approved these changes
Feb 24, 2023
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Changes LGTM.
The tests for Python 3.6 are failing...do we still need to support 3.6?
Member
It's btw not the PR that's causing tests to fail - CI fails also on master: https://github.com/nextstrain/cli/actions/runs/4266385449 I've made a PR to bump minimum supported Python version to 3.7: #256 |
…lready complete This messaging and signal handling is more confusing than helpful when attaching to a job that's already complete (i.e. in a terminal status). For such jobs, just exit normally when receiving a ^C (as if "detaching").
It can be annoying to sit thru the fetching and printing of large reams of log lines when attaching to a completed AWS Batch build to download the results. This is particularly true when downloading small bits of the results via --download, as the log fetching often takes longer than the selective download does!
tsibley
force-pushed
the
trs/aws-batch/attaching-to-complete-jobs
branch
from
1470bcd to
f1f491b
Compare
Contributor
Author
|
Rebased onto latest master to pick up fixes for CI (and fix changelog conflicts). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Testing