Skip to content

Bug fix for boundary handling #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
einola wants to merge 1 commit into from
Closed

Bug fix for boundary handling #803

einola wants to merge 1 commit into from

Conversation

@einola
Copy link
Member

@einola einola commented Mar 17, 2025 •
edited
Loading

Pull Request Title

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

Replaces the incorrect handling of Dirichlet boundaries in reinitnormalvelocity(). This could help improve the stability of the model, as I've seen some strange boundary behaviour before.

Test Description

Standard tests run.

Documentation Impact

N/A

Other Details

None

Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • File dates have been updated to reflect modification date
  • This change conforms to the conventions described in the README

@einola
Bug fix for boundary handling
97bfd51 
Replaces the incorrect handling of Dirichlet boundaries in
reinitnormalvelocity(). This could help improving the stability of the
model, as I've seen some strange boundary behaviour before.
@einola
Copy link
Member Author

einola commented Mar 17, 2025

@winzerle This is the code from you we were discussing the other day. My description above is very short - but maybe it's enough? Please feel free to edit it if you'd like.

@einola einola marked this pull request as draft March 17, 2025 10:51
@einola
Copy link
Member Author

einola commented May 6, 2025

Superceded by #797

@einola einola closed this May 6, 2025
@TomMelt TomMelt deleted the bugfix_boundaries branch May 19, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@einola