Could not find resource unsplash/js/user.js to load and other errors

[Siggi0904]

Describe the bug:
Hi, I've installed splash 3.0.1 at NC 29.0.5.
Configured Wikimedia Commons as source and "car,anime" as search tags.

Error for search tags: Your searchterms likely did not yield results for: WikimediaCommons
Better to geht this info direkt in settings.

In logs I get the following error: Could not find resource unsplash/js/user.js to load
I cannot collapse these error, the tab crashes at Firefox 130.0.

If I let search tags empty, I get following error:
Trying to access array offset on value of type null at /var/www/clients/client11/web18/web/nc/apps/unsplash/lib/Provider/WikimediaCommons.php#68

Undefined array key "query" at /var/www/clients/client11/web18/web/nc/apps/unsplash/lib/Provider/WikimediaCommons.php#68

Server:

• Nextcloud version: 29.0.5
• Splash-App version: 3.0.1

[newhinton]

This seems like there is a lot of unrelated issues going on.

Could not find resource unsplash/js/user.js to load

There is no such file in the sourcecode. What is trying to load this?

If I let search tags empty, I get following error:

That is expected. Though i probably should catch that and force some terms.

[newhinton]

The issue with wikimedia is that it's api is very "unreliable". "Car" does not work, but "Cat" does.

For valid searchterms you can try out this:

https://commons.wikimedia.org/w/api.php?action=query&generator=categorymembers&gcmtitle=Category:Cat&gcmlimit=100&gcmtype=file&prop=imageinfo&iiprop=url&format=json

Type this in your browser, and you get a list of images that will be choosen. Change Cat to your choosen searchterm. (Only one!)

For now, i would recommend using the wallhavencc provider.

[joshtrichards]

In logs I get the following error: Could not find resource unsplash/js/user.js to load
There is no such file in the sourcecode. What is trying to load this?

unsplash/templates/settings/personal.php

Line 10 in df0eb6b

script('unsplash', 'user');

PR #158 will fix this.

If I let search tags empty, I get following error:

Fixed in aba003e / released in v3.0.2.

Error for search tags: Your searchterms likely did not yield results for: WikimediaCommons
Better to geht this info direkt in settings.

Agreed. And we could probably do a better job dealing with other types of failures in the same spot. EDIT: Let's track that last item in #163 since that's when we'll likely improve the error handling surrounding HTTP requests.