chore(vue3): migrate from vuex to pinia #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
chore/vue3/migrate-to-pinia
branch
from
a2dc90e to
0747eae
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates state management from Vuex to Pinia as part of the preparation for Vue 3 migration. Key changes include replacing Vuex with Pinia in tests and main application modules, updating store implementations, and modifying component computed properties accordingly.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/unit/components/PersonalSettings.spec.js | Updated tests to use Pinia instead of Vuex |
| src/tests/unit/components/Device.spec.js | Updated tests to use Pinia and adjust store interaction |
| src/store.js | Migrated store implementation from Vuex to Pinia, including actions |
| src/main-settings.js | Adjusted initialization to use Pinia instead of Vuex |
| src/main-login-setup.js | Updated login setup to use Pinia |
| src/main-challenge.js | Migrated state handling for challenge components to Pinia |
| src/components/PersonalSettings.vue | Replaced Vuex computed property mappings with Pinia mappings |
| src/components/Device.vue | Updated component store access to use Pinia |
| src/components/Challenge.vue | Replaced Vuex getter mapping with Pinia state mapping |
| src/components/AddDeviceDialog.vue | Adjusted component logic to interact with the Pinia-based store |
Files not reviewed (1)
- package.json: Language not supported
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation work for migrating to Vue 3.