Skip to content

[stable26] Fix npm audit #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
st3iny merged 2 commits into from
Feb 22, 2024
Merged

[stable26] Fix npm audit #1461

st3iny merged 2 commits into from
Feb 22, 2024

Conversation

@nextcloud-command
Copy link
Contributor

@nextcloud-command nextcloud-command commented Oct 8, 2023

Auto-generated fix of npm audit

@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51619c2) 44.29% compared to head (1868019) 44.29%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             stable26    #1461   +/-   ##
===========================================
  Coverage       44.29%   44.29%           
  Complexity         99       99           
===========================================
  Files              19       19           
  Lines             298      298           
===========================================
  Hits              132      132           
  Misses            166      166
Flag Coverage Δ
unittests 44.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blizzz blizzz added this to the Nextcloud 26.0.8 milestone Oct 10, 2023
@blizzz blizzz mentioned this pull request Oct 10, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Oct 12, 2023

moving to 26.0.9

@miaulalala miaulalala removed their request for review October 12, 2023 12:54
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 212d543 to 7e7827b Compare October 22, 2023 03:05
@st3iny
Copy link
Member

st3iny commented Oct 27, 2023

CI fix at #1466.

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 7e7827b to 6b73b6e Compare October 29, 2023 03:30
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 6b73b6e to 4a1d917 Compare November 12, 2023 04:01
@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Nov 15, 2023

needs a rebase or recreate?

@blizzz
Copy link
Member

blizzz commented Nov 16, 2023

moving to 26.0.10

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch 2 times, most recently from bd1ed6a to e9dbd29 Compare November 26, 2023 03:13
@blizzz
Copy link
Member

blizzz commented Nov 28, 2023

Node tests are still failing

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from e9dbd29 to 2d79464 Compare December 3, 2023 03:16
@blizzz blizzz mentioned this pull request Dec 4, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Dec 7, 2023

moving to 26.0.11

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 2d79464 to 001b87b Compare December 10, 2023 03:15
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 001b87b to 8052b64 Compare December 17, 2023 03:00
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 8052b64 to 7a25a96 Compare December 31, 2023 02:55
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 7a25a96 to 41f6226 Compare January 7, 2024 03:14
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 41f6226 to b32b3a7 Compare January 14, 2024 03:31
@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
@blizzz
Copy link
Member

blizzz commented Jan 15, 2024

Node tests are still failing. Please take care @ChristophWurst @st3iny

@blizzz
Copy link
Member

blizzz commented Jan 18, 2024

moving to 26.0.12

@ChristophWurst ChristophWurst force-pushed the automated/noid/stable26-fix-npm-audit branch from b32b3a7 to 052ca23 Compare January 18, 2024 13:19
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 18, 2024

/compile amend /

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 052ca23 to 1aa32c8 Compare January 21, 2024 03:41
@blizzz
Copy link
Member

blizzz commented Jan 23, 2024 

Error: 

Vue packages version mismatch:

- [email protected] (/home/runner/work/twofactor_totp/twofactor_totp/node_modules/vue/dist/vue.runtime.common.js)
- [email protected] (/home/runner/work/twofactor_totp/twofactor_totp/node_modules/vue-template-compiler/package.json)

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 1aa32c8 to 31c7f1a Compare January 28, 2024 03:04
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 31c7f1a to 654b144 Compare February 4, 2024 03:10
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable26-fix-npm-audit branch from 654b144 to 11eebbb Compare February 11, 2024 02:51
This was referenced Feb 14, 2024
Merged
Closed
Merged
@st3iny
chore(deps-dev): bump @nextcloud/webpack-vue-config to ^5.5.1
1868019 
Required to keep vue and vue-template-compiler in sync and also fix
audits.

Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
st3iny approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny enabled auto-merge February 22, 2024 18:46
@st3iny st3iny disabled auto-merge February 22, 2024 18:53
@st3iny st3iny merged commit 2047042 into stable26 Feb 22, 2024
@st3iny st3iny deleted the automated/noid/stable26-fix-npm-audit branch February 22, 2024 19:38
@skjnldsv skjnldsv mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review dependencies

Projects

None yet

Milestone

Nextcloud 26.0.12

Development

Successfully merging this pull request may close these issues.

5 participants

@nextcloud-command @blizzz @st3iny @ChristophWurst