Skip to content

Fix: initialize undomanager for empty document #7962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjaminfrueh wants to merge 2 commits into from
Closed

Fix: initialize undomanager for empty document #7962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cff9c03
Fix: initialize undomanager for empty document
benjaminfrueh Nov 19, 2025
04db63c
Merge branch 'main' into fix/init-undomanager-empty-doc
benjaminfrueh Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/components/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,28 @@ export default defineComponent({
this.idle = false
},

initUndoManagerForEmptyDocument() {
if (
Copy link
Member

@juliusknorr juliusknorr Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that gets added to the history and pushing steps to the server? As discussed I'd be fine with this as a workaround but we should file an upstream issue at least.

Copy link
Contributor Author

@benjaminfrueh benjaminfrueh Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusknorr I clear the history after deleting the space, and in my test there were no steps added to the database in this process. I agree that an upstream issue for yjs should be created and this workaround should be removed once the issue is fixed or a better workaround is found.

Copy link
Member

@juliusknorr juliusknorr Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, would be fine with me then.

However tests seem to fail quite heavily. Maybe it has some unexpected side effects?

Copy link
Contributor Author

@benjaminfrueh benjaminfrueh Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some failing tests, such as the ones counting characters seem to be timing-related and caused by this change. Making the tests even more flaky with this workaround doesn't seem ideal. Maybe we should discuss and explore an alternative less invasive workaround for this.

this.editor.state.doc.textContent.length > 0
|| !this.editor.isEditable
) {
return
}

if (!this.editor.commands.insertContent(' ')) {
return
}

this.editor.commands.deleteRange({ from: 0, to: 1 })

const undoManager = this.editor.state.plugins
.map((p) => p.getState?.(this.editor.state)?.undoManager)
.find((um) => um?.clear)
undoManager?.clear()

this.dirty = false
},

onOpened({ document, session, content, documentState, readOnly }) {
this.document = document
this.readOnly = readOnly
Expand Down Expand Up @@ -520,6 +542,7 @@ export default defineComponent({
isRichEditor: this.isRichEditor,
})
}
this.initUndoManagerForEmptyDocument()
})
this.updateUser(session)
},
Expand Down
Loading