[stable31] fix/guest user dialog #7603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <[email protected]>
Together with the 2px border they match the 34px. input height. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
HTML Standard says about `<ul>` content: > Zero or more li and script-supporting elements. https://html.spec.whatwg.org/multipage/grouping-content.html#the-ul-element Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
`nextcloud-vue` 9 will introduce this by default for popups. The css rule is already bleeding in from other apps. Use `--default-clickable-area` as the default size of the avatars both in the trigger and in the popup. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
The clientId arg is not exposed in the tiptap type signature but provided by y-prosemirror anyway. See https://github.com/yjs/y-prosemirror/blob/f89fadd2a8bf15c0c7e6bfcac268883a5fa4e0f8/src/plugins/cursor-plugin.js#L118 Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Also remove `required: false` as that is the default. Signed-off-by: Max <[email protected]>
Use `var(--default-clickable-area)` in css instead. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]> [skip ci]
Collaborator
|
won't backport this. Too many ui changes etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7555
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.