Multiline tables with block node content #7523

mejo- · 2025-08-01T09:30:20Z

📝 Summary

Allow any block node type as children of table cells
Use markdown-it-multimd-table to parse markdown tables
Implement new markdown serializer for whole tables to support multi-line cells
Allow headerless tables
Support cell alignment in serializer, but only serialize cells that contain just text, paragraph and image nodes. All other nodes can be problematic and result in broken markdown that cannot be parsed again.
Resolves: Pasting an image into a table splits it #4047
Resolves: Inserting Images into Table Cells #4687
Resolves: Text rich editor column smart picker content breaks tables #7582

🖼️ Screenshots

🏡 Editor	Serialized Markdown

🚧 TODO

Allow block+ as content for tableCell. For some reason, allowing blockquotes results in all cell rows being serialized to markdown as blockquote. I didn't find out yet why this is the case (fixed magically, probably something upstream in Tiptap)
Parsing single-line block elements (like lists with one item, blockquotes with one line) from markdown is broken
Single-line table rows take more vertical space now
~~2x return used to create/jump to next row. This is currently broken. Do we want it back?~~ (we don't)
~~Optionally remove our custom newline special-handling with <br> in table cells~~ (let's keep it to not break backwards-compatibility when parsing existing tables)
Reset sessions on app update
Custom paste handler breaks pasting into code blocks. We need to replace it with a paste handler that prevents nested tables and allows everything else
Prevent nested tables via filterTransaction (as suggested here)

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

codecov · 2025-08-01T13:19:00Z

Codecov Report

❌ Patch coverage is 74.24242% with 34 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/nodes/Table/TableCell.js	27.50%	24 Missing and 5 partials ⚠️
src/nodes/Table/TableCaption.js	0.00%	1 Missing ⚠️
src/nodes/Table/TableHeadRow.js	0.00%	1 Missing ⚠️
src/nodes/Table/TableHeader.js	0.00%	1 Missing ⚠️
src/nodes/Table/TableRow.js	0.00%	1 Missing ⚠️
src/nodes/Table/markdown.ts	98.85%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

max-nextcloud · 2025-08-16T16:19:07Z

@mejo- Did you figure out what prevents nesting a table in a table right now?

mejo- · 2025-08-17T19:01:54Z

@mejo- Did you figure out what prevents nesting a table in a table right now?

Not exactly, but I guess it's rather a broken can() (or however this command to check whether the feature is possible at current cursor position is called). Pasting a table into a table cell works currently. That's why I added the two TODO points to make it technically impossible to add nested tables (via filterTransaction) and to filter out nested tables in handlePaste().

Aveyron-RetD · 2025-08-25T14:08:12Z

Will this fix as well, rich previews added with the smart picker ?
#7582

janbaum · 2025-09-26T12:52:38Z

2x return used to create/jump to next row. This is currently broken. Do we want it back?

Just wanted to say that I would love this being broken 🫠

max-nextcloud · 2025-12-03T13:55:49Z

src/nodes/Table/TableCell.js

+						if (!tablePaste) {
+							return slice
+						}
+
+						if (
+							slice.content.childCount === 1
+							&& slice.content.firstChild?.type.name === 'table'
+						) {
+							const tableChild = slice.content.firstChild.firstChild
+							if (
+								(tableChild.childCount === 1
+									&& tableChild.type.name === 'tableRow')
+								|| tableChild.type.name === 'tableHeadRow'
+							) {
+								const rowChild = tableChild.firstChild
+								if (
+									(rowChild.childCount === 1
+										&& rowChild.type.name === 'tableCell')
+									|| rowChild.type.name === 'tableHeader'
+								) {
+									return new Slice(rowChild.content, 0, 0)
+								}
+							}
+						}
+
+						console.warn('Nested tables are not supported')
+						alert(
+							t(
+								'text',
+								'A table was pasted into a table. Nested tables are not supported.',
+							),
+						)
+
+						const newSlice = new Slice(Fragment.empty, 0, 0)
+						return newSlice


Do we really need to rule out multi cell pastes?
Would that effectively lead to nested tables or just paste the cells at the current cursor position?

The latter seems like it might be useful and if it's already the current behavior would be nice to keep it.

I gave it a try by selecting two cells and pasting them and it resulted in a full new table being added to the cell, i.e. a nested table. If that's what you mean (also what we talked about last week), then I fear that's not possible out of the box and not working already now.

max-nextcloud

Looks good code wise. Have not tested it yet though.

Allow paragraphs, lists, code blocks and images in table cells for now. Signed-off-by: Jonas <[email protected]>

Signed-off-by: Jonas <[email protected]>

Table cells with lists or code blocks are hardcoded to left alignment though, as everything else would break markdown parsing later. Signed-off-by: Jonas <[email protected]>

Signed-off-by: Jonas <[email protected]>

Dashes in nodes names are not nice and this PR changes the editor schema anyway. Signed-off-by: Jonas <[email protected]>

Unnecessary and breaks serializing e.g. nested lists. Signed-off-by: Jonas <[email protected]>

Signed-off-by: Jonas <[email protected]>

Also add tests for tables with complex nested structures in their cells. Signed-off-by: Jonas <[email protected]>

With multiline table cells, we don't want to jump into next table row any longer when pressing <Return> two times in a row. Signed-off-by: Jonas <[email protected]>

Signed-off-by: Jonas <[email protected]>

Single line block node cell content is not valid markdown. Signed-off-by: Jonas <[email protected]>

The editor schema changed as table cells now support block node content. Signed-off-by: Jonas <[email protected]>

Check pasted content for possibly nested table when pasting to a table cell. Show an alert if nested table is detected. Add some extra logic to detect if just one table cell got selected and copied, which results in a table with one row and cell in the clipboard. Unwrap the cell content in this case and paste it. Add `filterTransaction` to prevent applying a transaction that would result in nested tables. This is meant as an extra low-level protection against nested tables. Signed-off-by: Jonas <[email protected]>

We don't support headerless tables in the editor schema anyway, so let's not add partial support for them that results in markdown being altered. Signed-off-by: Jonas <[email protected]>

Signed-off-by: Jonas <[email protected]>

mejo- self-assigned this Aug 1, 2025

mejo- added enhancement New feature or request 2. developing feature: tables labels Aug 1, 2025

mejo- force-pushed the feat/multiline_tables branch 3 times, most recently from b6526cb to c619227 Compare August 1, 2025 13:16

mejo- force-pushed the feat/multiline_tables branch from c619227 to b18ab8b Compare August 3, 2025 17:59

mejo- added 3. to review and removed 2. developing labels Aug 3, 2025

mejo- marked this pull request as ready for review August 3, 2025 17:59

mejo- requested a review from max-nextcloud as a code owner August 3, 2025 17:59

mejo- force-pushed the feat/multiline_tables branch 2 times, most recently from ac21086 to 8e40758 Compare August 14, 2025 14:36

mejo- added 2. developing and removed 3. to review labels Aug 14, 2025

mejo- changed the title ~~Multiline tables with paragraphs, lists, code blocks and images~~ Multiline tables with block node content Aug 14, 2025

juliusknorr added this to 📝 Office team Nov 5, 2025

juliusknorr moved this to 💡 To discuss in 📝 Office team Nov 5, 2025

juliusknorr assigned silverkszlo Nov 5, 2025

juliusknorr moved this from 💡 To discuss to 📄 To do (~10 entries) in 📝 Office team Nov 6, 2025

mejo- force-pushed the feat/multiline_tables branch 4 times, most recently from bba037a to 48ccc4c Compare November 25, 2025 17:11

mejo- force-pushed the feat/multiline_tables branch 3 times, most recently from 12cb94a to 30e25f0 Compare December 3, 2025 11:10

max-nextcloud reviewed Dec 3, 2025

View reviewed changes

mejo- added 18 commits December 8, 2025 17:34

feat(table): Allow multiline cells in tables

ba258d3

Allow paragraphs, lists, code blocks and images in table cells for now. Signed-off-by: Jonas <[email protected]>

test: Add markdownThroughEditor test for complex table

e161ca6

Signed-off-by: Jonas <[email protected]>

feat(tables): Support headerless tables

2f097bb

Signed-off-by: Jonas <[email protected]>

fix(table): Fix cell alignment in serialized markdown

ca694ea

Table cells with lists or code blocks are hardcoded to left alignment though, as everything else would break markdown parsing later. Signed-off-by: Jonas <[email protected]>

chore(table): Remove dead code from table node classes

94ad2f0

Signed-off-by: Jonas <[email protected]>

test(cy): Adjust mulitline cell test

b1e731d

Signed-off-by: Jonas <[email protected]>

chore(imageInline): Rename node

986345b

Dashes in nodes names are not nice and this PR changes the editor schema anyway. Signed-off-by: Jonas <[email protected]>

fix(table): Don't trim cell lines

a8a3057

Unnecessary and breaks serializing e.g. nested lists. Signed-off-by: Jonas <[email protected]>

chore(tableCaption): remove obsolete parameters from toMarkdown

0a562ea

Signed-off-by: Jonas <[email protected]>

fix(table): Allow all block elements as table children

bec62da

Also add tests for tables with complex nested structures in their cells. Signed-off-by: Jonas <[email protected]>

chore(table): Remove custom 2x return handling

4a6b997

With multiline table cells, we don't want to jump into next table row any longer when pressing <Return> two times in a row. Signed-off-by: Jonas <[email protected]>

fix(table): No margin-bottom for last paragraph in table cell

9d9ea42

Signed-off-by: Jonas <[email protected]>

fix(table): Make sure cells with block node content span over two lines

6b3db06

Single line block node cell content is not valid markdown. Signed-off-by: Jonas <[email protected]>

fix(table): Reset document sessions on upgrade

e3c8c82

The editor schema changed as table cells now support block node content. Signed-off-by: Jonas <[email protected]>

fix(table): Drop support for parsing headerless markdown tables

0f42ab5

We don't support headerless tables in the editor schema anyway, so let's not add partial support for them that results in markdown being altered. Signed-off-by: Jonas <[email protected]>

fix(table): don't mutate looped variable in rowToMarkdown()

cb624cf

Signed-off-by: Jonas <[email protected]>

chore(table): Refactor rowToMarkdown() and normalizeCells

f970ac9

Signed-off-by: Jonas <[email protected]>

mejo- force-pushed the feat/multiline_tables branch from 30e25f0 to 3258953 Compare December 8, 2025 16:35

fix(table): CSS rules to make cell selections visible

b625cbb

Signed-off-by: Jonas <[email protected]>

mejo- force-pushed the feat/multiline_tables branch from 3258953 to b625cbb Compare December 8, 2025 17:13

max-nextcloud approved these changes Dec 11, 2025

View reviewed changes

mejo- merged commit ab7ed54 into main Dec 11, 2025
69 checks passed

mejo- deleted the feat/multiline_tables branch December 11, 2025 14:47

github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Dec 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiline tables with block node content #7523

Multiline tables with block node content #7523

Uh oh!

mejo- commented Aug 1, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 1, 2025 •

edited

Loading

Uh oh!

max-nextcloud commented Aug 16, 2025

Uh oh!

mejo- commented Aug 17, 2025

Uh oh!

Aveyron-RetD commented Aug 25, 2025

Uh oh!

janbaum commented Sep 26, 2025

Uh oh!

max-nextcloud Dec 3, 2025

Uh oh!

mejo- Dec 3, 2025

Uh oh!

max-nextcloud left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Multiline tables with block node content #7523

Multiline tables with block node content #7523

Uh oh!

Conversation

mejo- commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🖼️ Screenshots

🚧 TODO

🏁 Checklist

Uh oh!

codecov bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

max-nextcloud commented Aug 16, 2025

Uh oh!

mejo- commented Aug 17, 2025

Uh oh!

Aveyron-RetD commented Aug 25, 2025

Uh oh!

janbaum commented Sep 26, 2025

Uh oh!

max-nextcloud Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

mejo- Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

max-nextcloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mejo- commented Aug 1, 2025 •

edited

Loading

codecov bot commented Aug 1, 2025 •

edited

Loading