Skip to content

[stable31] Bring back and refactor keymap, add focus trap to plain text editor #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mejo- merged 12 commits into from
May 21, 2025
Merged

[stable31] Bring back and refactor keymap, add focus trap to plain text editor #7242

mejo- merged 12 commits into from
May 21, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented May 21, 2025 •
edited by mejo-
Loading

Backport of #7204

@backportbot backportbot bot requested review from max-nextcloud and mejo- May 21, 2025 10:13
@backportbot backportbot bot added bug Something isn't working 3. to review technical debt labels May 21, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.6 milestone May 21, 2025
mejo- added 2 commits May 21, 2025 12:16
@mejo-
fix(editor): bring back our custom keymap extension
58fdb60 
Signed-off-by: Jonas <[email protected]>
@mejo-
chore(keymap): Remove obsolete <Mod>-<F> overwrite
13d75db 
The keymap extension was not in use for quite some time and I'm now
longer able to reproduce issues with <Mod>-<F> without the overwrite
either.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the backport/7204/stable31 branch from 8b2f002 to 9d0c2df Compare May 21, 2025 10:28
@mejo- mejo- force-pushed the backport/7204/stable31 branch from 9d0c2df to c796eb1 Compare May 21, 2025 10:30
@codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.41667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 59.28%. Comparing base (15f2e7f) to head (514b4f8).
Report is 13 commits behind head on stable31.

Files with missing lines Patch % Lines
src/nodes/CodeBlock/codeBlockShortcuts.js 59.57% 19 Missing ⚠️
src/extensions/Keymap.js 84.31% 8 Missing ⚠️
src/components/PlainTextReader.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           stable31    #7242      +/-   ##
============================================
+ Coverage     52.20%   59.28%   +7.07%     
============================================
  Files           286      287       +1     
  Lines         40798    36131    -4667     
  Branches        817      835      +18     
============================================
+ Hits          21300    21420     +120     
+ Misses        19382    14596    -4786     
+ Partials        116      115       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo- mejo- force-pushed the backport/7204/stable31 branch from c796eb1 to 514b4f8 Compare May 21, 2025 10:36
@mejo- mejo- marked this pull request as ready for review May 21, 2025 10:37
@mejo- mejo- enabled auto-merge May 21, 2025 10:37
@mejo- mejo- merged commit ac615d8 into stable31 May 21, 2025
66 checks passed
@mejo- mejo- deleted the backport/7204/stable31 branch May 21, 2025 10:46
@nextcloud-bot nextcloud-bot mentioned this pull request Jun 4, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working technical debt

Projects

None yet

Milestone

Nextcloud 31.0.6

Development

Successfully merging this pull request may close these issues.

2 participants

@mejo-