-
Notifications
You must be signed in to change notification settings - Fork 111
fix: Adjust padding in table cell and header components #7185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c98b236 to
89b1916
Compare
|
Thanks for the contribution @AIlkiv, much appreciated! Could you fix the code style issues reported by prettier? |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #7185 +/- ##
==========================================
+ Coverage 51.85% 52.53% +0.68%
==========================================
Files 479 479
Lines 41467 41522 +55
Branches 1004 1023 +19
==========================================
+ Hits 21504 21815 +311
+ Misses 19858 19605 -253
+ Partials 105 102 -3 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
Signed-off-by: ailkiv <[email protected]>
89b1916 to
93c7d12
Compare
|
@mejo- please, run pipeline again |
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and indeed fixes line padding. Thanks so much!
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/7185/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c7d12e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7185/stable31Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/7185/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
π Summary
I replaced the use of line-height with padding so that the text would be displayed correctly when it is in several lines.
The problem appeared after: #6150
πΌοΈ Screenshots
π§ TODO
π Checklist
npm run lint/npm run stylelint/composer run cs:check)