Skip to content

Conversation

@AIlkiv
Copy link
Contributor

@AIlkiv AIlkiv commented May 6, 2025

πŸ“ Summary

I replaced the use of line-height with padding so that the text would be displayed correctly when it is in several lines.

The problem appeared after: #6150

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
before after

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@AIlkiv AIlkiv requested review from max-nextcloud and mejo- as code owners May 6, 2025 10:31
@AIlkiv AIlkiv force-pushed the fix/cleanup-table-spacing branch from c98b236 to 89b1916 Compare May 6, 2025 10:33
@mejo-
Copy link
Member

mejo- commented May 6, 2025

Thanks for the contribution @AIlkiv, much appreciated! Could you fix the code style issues reported by prettier?

@mejo- mejo- self-assigned this May 6, 2025
@mejo- mejo- added the bug Something isn't working label May 6, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in πŸ“ Office team May 6, 2025
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to πŸ‘€ In review in πŸ“ Office team May 6, 2025
@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 52.53%. Comparing base (5024275) to head (93c7d12).
Report is 133 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7185      +/-   ##
==========================================
+ Coverage   51.85%   52.53%   +0.68%     
==========================================
  Files         479      479              
  Lines       41467    41522      +55     
  Branches     1004     1023      +19     
==========================================
+ Hits        21504    21815     +311     
+ Misses      19858    19605     -253     
+ Partials      105      102       -3     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AIlkiv AIlkiv force-pushed the fix/cleanup-table-spacing branch from 89b1916 to 93c7d12 Compare May 6, 2025 11:04
@AIlkiv
Copy link
Contributor Author

AIlkiv commented May 6, 2025

@mejo- please, run pipeline again

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and indeed fixes line padding. Thanks so much!

@mejo- mejo- merged commit 0413404 into nextcloud:main May 6, 2025
66 checks passed
@github-project-automation github-project-automation bot moved this from πŸ‘€ In review to β˜‘οΈ Done in πŸ“ Office team May 6, 2025
@mejo-
Copy link
Member

mejo- commented May 6, 2025

/backport to stable31

@mejo-
Copy link
Member

mejo- commented May 6, 2025

/backport to stable30

@mejo-
Copy link
Member

mejo- commented May 6, 2025

/backport to stable31

@backportbot
Copy link

backportbot bot commented May 6, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/7185/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93c7d12e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7185/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/7185/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feedback-requested

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants