Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 6, 2024

We want to prevent nesting interactive widgets, so this will ensure that we know about that text is rendered as an embedding with nextcloud/server#44012

Follow up to check

  • Check if we can just use inject in the paragraph component if we use the viewer vue instance

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Mar 6, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Mar 6, 2024

One would argue that this is not an official Viewer prop yet 🙈
But it make sense, we'll need to consider this for Viewer 3

@juliusknorr juliusknorr force-pushed the fix/handle-is-embedded branch from 309b7e3 to d3ea196 Compare March 7, 2024 10:05
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments. One of them might point at a conceptual issue though... Do we want to render the previews inside embedded content non-interactive or not at all?

If we don't render the Preview nothing will be shown - not even the embedded link. So maybe we leave out the Preview nodes all together then and at least show the link?

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr force-pushed the fix/handle-is-embedded branch from d3ea196 to a4a572f Compare March 7, 2024 10:42
@juliusknorr juliusknorr merged commit 885810e into main Mar 7, 2024
@juliusknorr juliusknorr deleted the fix/handle-is-embedded branch March 7, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants