Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 5, 2023

📝 Summary

Fix cypress tests after nextcloud/server#35772

  • ci(cypress): Fix recent files list selector
  • ci(cypress): Adapt showHiddenFiles to new settings modal selectors

Todo

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jan 5, 2023



Test summary

116 0 0 0Flakiness 0


Run details

Project Text
Status Passed
Commit f774b44
Started Jan 5, 2023 10:20 AM
Ended Jan 5, 2023 10:24 AM
Duration 03:31 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorr juliusknorr requested review from a team, max-nextcloud and mejo- and removed request for a team January 5, 2023 07:33
@juliusknorr juliusknorr force-pushed the fix/noid/master-files branch from 37aee2c to f774b44 Compare January 5, 2023 10:09
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.
Looks like the required change in server has been merged... at least our test branch is not overwritten anymore. So this seems good to go.

@max-nextcloud max-nextcloud merged commit fed8484 into master Jan 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/master-files branch January 5, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants