Skip to content

Conversation

@juliusknorr
Copy link
Member

📝 Summary

Partly fix for #3506 to always update the alt text when the input looses focus.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr juliusknorr requested review from a team, julien-nc and luka-nextcloud and removed request for a team January 3, 2023 17:41
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jan 3, 2023
@cypress
Copy link

cypress bot commented Jan 3, 2023



Test summary

116 0 0 0Flakiness 1


Run details

Project Text
Status Passed
Commit 83d1ac7
Started Jan 4, 2023 7:41 AM
Ended Jan 4, 2023 7:44 AM
Duration 02:45 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/nodes/Table.spec.js Flakiness
1 table plugin > Keep alignment on new row

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @juliushaertl.

Didn't test, but code looks good.

This will fix #2250.

@juliusknorr juliusknorr force-pushed the bugfix/noid/image-blur branch from 209f10f to 144c917 Compare January 4, 2023 07:32
@juliusknorr
Copy link
Member Author

/compile amend /

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit e3d20df into master Jan 4, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/image-blur branch January 4, 2023 07:58
@mejo-
Copy link
Member

mejo- commented Jan 4, 2023

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants