Fix bullet list input role for CJK input #2752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
max-nextcloud
approved these changes
Jul 25, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Good catch, minimal fix to the point -- thanks a lot!
I wonder if there would be an easy way to test this. But i don't think we're testing input rules yet.
juliusknorr
approved these changes
Jul 25, 2022
Member
|
/compile amend / |
When using IME for CJK character input it is called after the composing is finished, at this point there might be more than one character. Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/2749
branch
from
48e1060 to
46ff9bb
Compare
Contributor
Author
I wanted to add a cypress test, but I did not find a way to test IME input |
Contributor
Author
|
I think this should also be backported to stable 24 |
Member
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using IME for CJK character input it is called after the composing
is finished, at this point there might be more than one character.
Example
Before entering the same work (
sakura) as Japanese Kanji and Hiragana, Kanji is one symbol so it worked, Hiragana are three syllables symbols so it does not:After this patch using IME works as expected:
