fix(reactions): Prevent accidental reaction toggle when long pressing #2368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When long pressing on a reaction bubble to see "who reacted", users would sometimes accidentally toggle the reaction (add/remove it) if they released their finger before the context menu threshold (~0.5s) was reached.
Root Cause
The
ReactionsView(UICollectionView) handles taps viadidSelectItemAtindependently of the table view's context menu system. When a long press didn't quite reach the context menu threshold, the touch was interpreted as a tap, triggering an unwanted reaction toggle.Solution
Track the touch duration in
ReactionsView:touchesBeganrecords the start timetouchesCancelledclears itdidSelectItemAtchecks the duration:This threshold (0.25s) provides a buffer below the context menu's ~0.5s threshold while still allowing normal quick taps to work.
Test plan