Skip to content

Upload profile picture from camera #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 2 commits into from
Jul 7, 2022
Merged

Upload profile picture from camera #2172

AndyScherzinger merged 2 commits into from
Jul 7, 2022

Conversation

@AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Jun 28, 2022 •
edited
Loading

Fixes #788
Fixes #1604

@AlvaroBrey AlvaroBrey force-pushed the feature/788/upload-avatar-from-camera branch from 0598f30 to 83529e3 Compare June 28, 2022 15:08
@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Jun 28, 2022
@AlvaroBrey AlvaroBrey force-pushed the feature/788/upload-avatar-from-camera branch from 83529e3 to 67744e3 Compare June 29, 2022 09:24
@AlvaroBrey AlvaroBrey marked this pull request as ready for review June 29, 2022 11:31
@AlvaroBrey AlvaroBrey requested review from mahibi and timkrueger June 29, 2022 11:31
@AlvaroBrey AlvaroBrey changed the title WIP: upload profile picture from camera Upload profile picture from camera Jun 29, 2022
@AlvaroBrey AlvaroBrey added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 29, 2022
@AlvaroBrey
Copy link
Member Author

AlvaroBrey commented Jul 6, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/788/upload-avatar-from-camera branch from 67744e3 to dad7aae Compare July 6, 2022 10:54
@AndyScherzinger AndyScherzinger force-pushed the feature/788/upload-avatar-from-camera branch from dad7aae to 95119ba Compare July 7, 2022 11:52
AndyScherzinger
AndyScherzinger approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely!

@AndyScherzinger AndyScherzinger merged commit 1577a99 into master Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/788/upload-avatar-from-camera branch July 7, 2022 11:57
@AndyScherzinger AndyScherzinger added this to the 15.0.0 milestone Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2172-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jul 7, 2022

Lint

TypemasterPR
Warnings116116
Errors11

SpotBugs (new)

Warning Type Number
Bad practice Warnings 8
Correctness Warnings 35
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 23
Performance Warnings 22
Security Warnings 2
Dodgy code Warnings 65
Total 166

SpotBugs (master)

Warning Type Number
Bad practice Warnings 8
Correctness Warnings 35
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 23
Performance Warnings 22
Security Warnings 2
Dodgy code Warnings 65
Total 166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@timkrueger timkrueger Awaiting requested review from timkrueger

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

14.2.0

Development

Successfully merging this pull request may close these issues.

Allow to take new profile picture with camera create new profile avatar image with camera

4 participants

@AlvaroBrey @nextcloud-android-bot @AndyScherzinger