Skip to content

fix(test): deactivate the deactivation of the contacts search provider #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 3 commits into from
Dec 7, 2023
Merged

fix(test): deactivate the deactivation of the contacts search provider #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a32ca26
fix(test): deactivate the deactivation of the contacts search provider
Dec 5, 2023
3315e37
fix(tests): small adjustments
Dec 6, 2023
c6ac4af
tests: Wait for modal to be visible
juliusknorr Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cypress/e2e/tables-rows.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Rows for a table', () => {
cy.get('.modal__content [aria-label="Increase stars"]').click().click()
cy.get('.modal-container button').contains('Save').click()

cy.get('.modal-container').should('not.exist')
cy.get('.modal-container:visible').should('not.exist')
cy.get('.custom-table table').contains('My first task').should('exist')
})

Copy link
Contributor

@enjeck enjeck Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Create, Edit and Delete tests here are too coupled to each other, and one failing will impact the others. Imo, it'll be nice if they're made independent or combined into a single test.

Expand All @@ -34,7 +34,7 @@ describe('Rows for a table', () => {
cy.get('.modal__content [aria-label="Increase stars"]').click().click()
cy.get('.modal-container button').contains('Save').click()

cy.get('.modal-container').should('not.exist')
cy.get('.modal-container:visible').should('not.exist')
cy.get('.custom-table table').contains('Changed column value').should('exist')
})

Expand All @@ -44,7 +44,7 @@ describe('Rows for a table', () => {
cy.get('.modal-container button').contains('Delete').click()
cy.get('.modal-container button').contains('I really want to delete this row!').click()

cy.get('.modal-container').should('not.exist')
cy.get('.modal-container:visible').should('not.exist')
cy.get('.custom-table table').contains('Changed column value').should('not.exist')
})
})
5 changes: 4 additions & 1 deletion cypress/e2e/tables-table.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ describe('Manage a table', () => {
cy.contains('.app-menu-entry--label', 'Tables').click()
cy.contains('button', 'Create new table').click()
cy.get('.tile').contains('ToDo').click({ force: true })
cy.get('.modal__content').should('be.visible')
cy.get('.modal__content input[type="text"]').clear().type('to do list')
cy.contains('button', 'Create table').click()

Expand All @@ -30,7 +31,8 @@ describe('Manage a table', () => {
cy.get('[data-cy="customTableAction"] button').click()
cy.get('.action-button__text').contains('Edit table').click()

cy.get('.modal-container input').clear().type('ToDo list')
cy.get('.modal__content').should('be.visible')
cy.get('.modal-container input').last().clear().type('ToDo list')
cy.get('.modal-container button').contains('Save').click()

cy.wait(10).get('.toastify.toast-success').should('be.visible')
Expand All @@ -42,6 +44,7 @@ describe('Manage a table', () => {
cy.get('[data-cy="customTableAction"] button').click()
cy.get('.action-button__text').contains('Edit table').click()

cy.get('.modal__content').should('be.visible')
cy.get('.modal-container button').contains('Delete').click()
cy.get('.modal-container button').contains('I really want to delete this table!').click()

Expand Down
3 changes: 2 additions & 1 deletion cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ Cypress.Commands.add('createTextLinkColumn', (title, ressourceProvider, firstCol
// deactivate unwanted provider
cy.get('.typeSelection span label').contains('Url', { matchCase: false }).click()
cy.get('.typeSelection span label').contains('Files').click()
cy.get('.typeSelection span label').contains('Contacts').click()
// TODO is the contacts search provider deactivated by default beginning with nc28
// cy.get('.typeSelection span label').contains('Contacts').click()

ressourceProvider.forEach(provider =>
cy.get('.typeSelection span label').contains(provider, { matchCase: false }).click(),
Expand Down