Skip to content

feat(avatar): Use the first emoji of room names as avatar emoji#9424

Merged
nickvergessen merged 3 commits intomasterfrom
feat/8444/populate-emoji-from-roomname-as-avatar
May 2, 2023
Merged

feat(avatar): Use the first emoji of room names as avatar emoji#9424
nickvergessen merged 3 commits intomasterfrom
feat/8444/populate-emoji-from-roomname-as-avatar

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 2, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks suuuper cool! :) ✨

@nickvergessen nickvergessen requested a review from vitormattos May 2, 2023 15:31
@nickvergessen nickvergessen force-pushed the feat/8444/populate-emoji-from-roomname-as-avatar branch from 6db9e11 to f0d4af6 Compare May 2, 2023 15:33
@mahibi
Copy link

mahibi commented May 2, 2023

when the conversation name is changed, the emoji is not updated:

grafik

@vitormattos
Copy link
Contributor

After merge this PR will be necessary rebase #9423 with this changes and make possible to change the avatar when change the conversation name.

@nickvergessen
Copy link
Member Author

when the conversation name is changed, the emoji is not updated:

It's only the browser caching the image for 24h

@nickvergessen nickvergessen enabled auto-merge May 2, 2023 18:19
@SystemKeeper
Copy link
Contributor

when the conversation name is changed, the emoji is not updated:

It's only the browser caching the image for 24h

Can’t we just get the md5 of the emoji?

@nickvergessen nickvergessen disabled auto-merge May 2, 2023 20:34
@nickvergessen nickvergessen merged commit bcea5d7 into master May 2, 2023
@nickvergessen nickvergessen deleted the feat/8444/populate-emoji-from-roomname-as-avatar branch May 2, 2023 20:34
@ShGKme
Copy link
Contributor

ShGKme commented May 3, 2023

Can’t we just get the md5 of the emoji?

Do you mean, to calculate md5 for each conversation everywhere?

@SystemKeeper
Copy link
Contributor

Do you mean, to calculate md5 for each conversation everywhere?

For cache busting we need a way to identify if an avatar changed. For default avatars the md5 of the filename is used, for custom avatars I think the hash is already at the filename or something, and for emojis this is added at https://github.com/nextcloud/spreed/pull/9423/files#diff-a7e5eb4728a4ad105af312d21ceb1bd6dd7a70068ba67d4b1881099dcae1076bR289-R291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to set an emoji as a conversation avatar

7 participants