feat(avatar): Use the first emoji of room names as avatar emoji#9424
Conversation
Signed-off-by: Joas Schilling <[email protected]>
jancborchardt
left a comment
There was a problem hiding this comment.
Looks suuuper cool! :) ✨
…is fit in the circle Signed-off-by: Joas Schilling <[email protected]>
6db9e11 to
f0d4af6
Compare
|
After merge this PR will be necessary rebase #9423 with this changes and make possible to change the avatar when change the conversation name. |
It's only the browser caching the image for 24h |
Signed-off-by: Joas Schilling <[email protected]>
Can’t we just get the md5 of the emoji? |
Do you mean, to calculate |
For cache busting we need a way to identify if an avatar changed. For default avatars the md5 of the filename is used, for custom avatars I think the hash is already at the filename or something, and for emojis this is added at https://github.com/nextcloud/spreed/pull/9423/files#diff-a7e5eb4728a4ad105af312d21ceb1bd6dd7a70068ba67d4b1881099dcae1076bR289-R291 |

☑️ Resolves
🖼️ Screenshots
🏁 Checklist
docs/has been updated or is not required