[stable26] feat: add utils for generating absolute links and copy a chat link#9141
Merged
nickvergessen merged 4 commits intostable26from Mar 23, 2023
Merged
[stable26] feat: add utils for generating absolute links and copy a chat link#9141nickvergessen merged 4 commits intostable26from
nickvergessen merged 4 commits intostable26from
Conversation
- Add `generateAbsoluteUrl` util - Add `copyLinkToConversation` method for copying conversation links to the clipboard with dialogs - Remove unused - Use dialogs on new conversation confirmation Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
nickvergessen
requested changes
Mar 23, 2023
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Regression: the entries in the left sidebar are not linking to the rooms anymore, so you can no longer right-click => open in a new tab.
Contributor
I cannot reproduce |
Antreesy
approved these changes
Mar 23, 2023
Contributor
Antreesy
left a comment
There was a problem hiding this comment.
Also can't reproduce the bug. Works fine on Firefox and Chrome
marcoambrosini
approved these changes
Mar 23, 2023
Member
|
It's actually a regression from the Vue lib update i was testing before and I forgot to |
nickvergessen
approved these changes
Mar 23, 2023
Member
|
Moved to #9153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #9051