[stable26] Fix stopping recording service before it has fully started#9126
Merged
nickvergessen merged 2 commits intostable26from Mar 22, 2023
Merged
[stable26] Fix stopping recording service before it has fully started#9126nickvergessen merged 2 commits intostable26from
nickvergessen merged 2 commits intostable26from
Conversation
When the recording is stopped the helpers, like the display or the browser, are stopped. This might cause an exception to be thrown, but if the recording was still starting and it was not fully started yet there is no need to notify that failure to the Nextcloud server. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The recording is stopped in a different thread than it is started. Stopping the recording stops the helpers, like the display, but if they are stopped at the same time that they are being started there could be a race condition in which the helper is tried to be stopped in one thread and, immediately after that, the helper is started in the other thread. This is now handled by explicitly checking if the recording was stopped after starting each helper and aborting the start if it was. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
nickvergessen
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #9124