Fix RemoteVideoBlocker still active after removing its associated model#9125
Merged
nickvergessen merged 1 commit intomasterfrom Mar 22, 2023
Conversation
Once a CallParticipantModel is removed its associated RemoteVideoBlocker should no longer block the remote video. Otherwise a deferred blocking would be rejected by the HPB, as the remote peer is no longer available or, even worse, it could be accepted and block the video of the remote peer if it joined again since the original model was removed. To solve that now the RemoteVideoBlocker is destroyed once its associated model is removed, which causes the RemoteVideoBlocker to ignore any further call on its methods. Note that the RemoteVideoBlocker reference can not be nullified instead on the shared datas, as other components, like the VideoView, expect a RemoteVideoBlocker to be always available in its shared data. Internally ignoring further calls also makes the code more robust than just externally guarding any possible call. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
nickvergessen
approved these changes
Mar 22, 2023
Ivansss
approved these changes
Mar 22, 2023
nickvergessen
deleted the
fix-remotevideoblocker-still-active-after-the-callparticipantmodel-is-removed
branch
This was referenced Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test (scenario 1)
Result with this pull request
No error is printed in the console
Result without this pull request
Ignore unknown error(and, if expanded,client_not_found - No MCU client found to send message to) is printed (after 5 seconds) in the consoleHow to test (scenario 2)
Result with this pull request
The remote video works as expected
Result without this pull request
The remote video freezes