fix(API): Extend list of configs influencing X-Nextcloud-Talk-Hash he…#9118
Merged
nickvergessen merged 1 commit intomasterfrom Mar 21, 2023
Merged
Conversation
…ader Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
papercut
feature: api 🛠️
Member
Author
|
/backport to stable26 |
vitormattos
approved these changes
Mar 21, 2023
Comment on lines
+54
to
58
| Legend: | ||
|
|
||
| * `Hash` - Whether the changing the config changes the Talk version hash triggering clients to refresh capabilities | ||
| * 🖌️ - UI option in the admin settings available | ||
| * 💻 - Dedicated OCC command available |
Contributor
There was a problem hiding this comment.
Not mandatory, only a suggestion to be more readable in my opinion.
Suggested change
| Legend: | |
| * `Hash` - Whether the changing the config changes the Talk version hash triggering clients to refresh capabilities | |
| * 🖌️ - UI option in the admin settings available | |
| * 💻 - Dedicated OCC command available | |
| | Legend | Description | | |
| | ------ | -------------------------------------------------------------------------------------------------------- | | |
| | `Hash` | Whether the changing the config changes the Talk version hash triggering clients to refresh capabilities | | |
| | 🖌️ | UI option in the admin settings available | | |
| | 💻 | Dedicated OCC command available | |
nickvergessen
deleted the
bugfix/9107/improve-talk-version-hash-reactivity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9107
🏁 Checklist
docs/has been updated or is not required