Allow to receive messages without marking notifications as unread#9066
Merged
nickvergessen merged 1 commit intomasterfrom Mar 16, 2023
Merged
Conversation
SystemKeeper
changed the title
SystemKeeper
added
3. to review
enhancement
feature: chat 💬
nickvergessen
requested changes
Mar 15, 2023
vitormattos
suggested changes
Mar 16, 2023
SystemKeeper
force-pushed
the
feature/noid/mark-notifications-as-read-in-receive-messages
branch
from
5153392 to
2d7ef86
Compare
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
feature/noid/mark-notifications-as-read-in-receive-messages
branch
from
2d7ef86 to
d480f3a
Compare
Contributor
Author
|
Both comments addressed, rebased and squashed |
nickvergessen
approved these changes
Mar 16, 2023
vitormattos
approved these changes
Mar 16, 2023
Contributor
Author
|
Test failure seems unrelated?! |
nickvergessen
deleted the
feature/noid/mark-notifications-as-read-in-receive-messages
branch
Contributor
Author
|
/backport to stable26 |
| | `setReadMarker` | int | `1` to automatically set the read timer after fetching the messages, use `0` when your client calls `Mark chat as read` manually. (Default: `1`) | | ||
| | `includeLastKnown` | int | `1` to include the last known message as well (Default: `0`) | | ||
| | `noStatusUpdate` | int | Whether the "online" user status of the current user should be "kept-alive" (`1`) or not (`0`) (defaults to `0`) | | ||
| | `markNotificationsAsRead` | int | `0` to not mark notifications as read (Default: `1`, only available with `chat-read-status` capability) | |
Member
There was a problem hiding this comment.
Should be chat-keep-notifications ?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when retrieving new messages, notifications of the spreed app are marked as read by default:
spreed/lib/Chat/ChatManager.php
Lines 606 to 608 in 049c56f
This is usually fine, but when we want to retrieve messages in the background on the mobile clients (to have the messages ready when we open the app again).
This PR adds a new parameter
markNotificationsAsReadwhich allows to explicitly state that we do not want to mark notifications as read when retrieving messages.🏁 Checklist
docs/has been updated or is not required