Merged
Conversation
ShGKme
requested review from
Antreesy,
danxuliu,
marcoambrosini and
nickvergessen
10 tasks
- Define IS_DESKTOP global variable - Separate the config to common and web parts - Use cross-platform slashes on webpack rules' tests Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
Signed-off-by: Grigorii Shartsev <[email protected]>
ShGKme
force-pushed
the
feat/noid/prepare-for-desktop
branch
from
f09f2b5 to
deec41e
Compare
Contributor
Author
|
Rebased after #9048 |
11 tasks
marcoambrosini
approved these changes
Mar 17, 2023
Member
|
Merge? |
Member
|
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 TODO
webpack.config.jsintowebpack.config.jsandwebpack.common.config.jsused by desktop buildIS_DESKTOPbuild-time constantIS_DESKTOPas well as old build-time constantsif (IS_DESKTOP)in simple casesThis is a Draft:
There are more changes
🏁 Checklist
docs/has been updated or is not required