Skip to content

Set status to none when recording not found#9020

Closed
vitormattos wants to merge 1 commit intomasterfrom
feature/change-status-of-recording
Closed

Set status to none when recording not found#9020
vitormattos wants to merge 1 commit intomasterfrom
feature/change-status-of-recording

Conversation

@vitormattos
Copy link
Contributor

When is short the interval between start and stop request, isn't possible to store the stop request because the start didn't finished as well. Because this was changed error status "recording failed" to stauts equal to none (no recording).

🏁 Checklist

When is short the interval between start and stop request, isn't
possible to store the stop request because the start didn't finished as
well. Because this was changed error status "recording failed" to stauts
equal to none (no recording).

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants labels Mar 10, 2023
@vitormattos vitormattos added this to the 🖤 Next Major (27) milestone Mar 10, 2023
@vitormattos vitormattos self-assigned this Mar 10, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, the question is whether that is good enough for the recording server or whether it will finish to start and still record afterwards, but @danxuliu might know better.

@danxuliu
Copy link
Member

If the recording was not found the status must be changed to failed. Otherwise the following scenario would not be seen as a failure:

  • Start a recording
  • Kill the recording server
  • Start the recording server again
  • Stop the recording (which will trigger a recording not found, as the new recording server instance knows nothing about the recording)

Moreover, in the described scenario of stopping the recording while it is starting and has not fully started yet the failure notification comes from the recording server, it is not related to the API. Therefore closing in favour of #9124.

@danxuliu danxuliu closed this Mar 22, 2023
@danxuliu danxuliu deleted the feature/change-status-of-recording branch March 22, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: api 🛠️ OCS API for conversations, chats and participants

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants