Set status to none when recording not found#9020
Closed
vitormattos wants to merge 1 commit intomasterfrom
Closed
Conversation
When is short the interval between start and stop request, isn't possible to store the stop request because the start didn't finished as well. Because this was changed error status "recording failed" to stauts equal to none (no recording). Signed-off-by: Vitor Mattos <[email protected]>
Member
nickvergessen
left a comment
There was a problem hiding this comment.
Fine by me, the question is whether that is good enough for the recording server or whether it will finish to start and still record afterwards, but @danxuliu might know better.
Member
|
If the recording was not found the status must be changed to failed. Otherwise the following scenario would not be seen as a failure:
Moreover, in the described scenario of stopping the recording while it is starting and has not fully started yet the failure notification comes from the recording server, it is not related to the API. Therefore closing in favour of #9124. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When is short the interval between start and stop request, isn't possible to store the stop request because the start didn't finished as well. Because this was changed error status "recording failed" to stauts equal to none (no recording).
🏁 Checklist
docs/has been updated or is not required