Fix NcRichContenteditable styles overriding in NewMessageForm#8808
Merged
nickvergessen merged 1 commit intomasterfrom Feb 22, 2023
Merged
Fix NcRichContenteditable styles overriding in NewMessageForm#8808nickvergessen merged 1 commit intomasterfrom
NcRichContenteditable styles overriding in NewMessageForm#8808nickvergessen merged 1 commit intomasterfrom
Conversation
Antreesy
reviewed
Feb 21, 2023
Signed-off-by: Grigorii Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/noid/fix-richcontenteditable-overriding
branch
from
bea09ec to
6a29fcc
Compare
nickvergessen
approved these changes
Feb 22, 2023
nickvergessen
deleted the
fix/noid/fix-richcontenteditable-overriding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Screenshots
🚧 TODO
Style overriding in #4333 worked on local tests but actually depends on building order and other apps. For example,
NcRichContenteditablemay be loaded on the page several times. Another instance may be loaded after the Talk.Adding!importmakes styles independent of order and duplications.Increase specificity by combinator.
NcRichContenteditablestyles overriding inNewMessageForm🏁 Checklist
docs/has been updated or is not required