Make recording files visible in the specific section Media tab of the…#8798
Merged
nickvergessen merged 5 commits intomasterfrom Feb 23, 2023
Merged
Make recording files visible in the specific section Media tab of the…#8798nickvergessen merged 5 commits intomasterfrom
nickvergessen merged 5 commits intomasterfrom
Conversation
5 tasks
nickvergessen
requested changes
Feb 20, 2023
Member
|
I'm actually unsure if it should be 2 sections or one, but then again with the different types it might be better in split sections? |
Member
|
PS screenshot in #8800 |
Member
|
I think they should definitely go in the same section "Call recordings" |
Contributor
Author
|
Updated the web client implementation here: #8800 |
vitormattos
added a commit
that referenced
this pull request
Feb 23, 2023
#8798 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>
Member
That's not good enough, as it needs more coordination with mobile clients, breaks the pagination, etc. |
… sidebar After share the recording to room, this change will make the PR visible in a specific tab of shared items Signed-off-by: Vitor Mattos <vitor@php.rio>
#8798 (comment) Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
featuree/make-recording-visible
branch
from
2f5b02d to
6b40bff
Compare
Signed-off-by: Vitor Mattos <vitor@php.rio>
nickvergessen
approved these changes
Feb 23, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧 TODO
🏁 Checklist
docs/has been updated or is not required