Skip to content

Implement time to live #7327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 51 commits into from
Jul 1, 2022
Merged

Implement time to live #7327

nickvergessen merged 51 commits into from
Jul 1, 2022

Conversation

@vitormattos
Copy link
Contributor

@vitormattos vitormattos commented May 6, 2022 •
edited
Loading

Ref #7359

To implement

  • Documentation
  • Capability
  • Routes
  • Integration tests
  • Controller
  • Changes on Service
  • Run event before and after define the TTL
  • Job to trigger delete message
    - [ ] Run event before and after trigger the job
  • Remove TTL capability if the systemcron is disabled
  • Notify clients by system message with the ids of deleted messages to make possible clients remove the messages from message list without wait for page reload.
  • Delete orphans reactions.
    Scenario:
    set ttl to 10 min, 10:30 am
    send message X, 10:35 am
    react to message X in , 10:45 am
    apply expire TTL job at 10:46 am
    the message X will be deleted and the orphan reaction also need be deleted
    - [ ] Delete shared files and unshare files replaced by ⏳ Expiring messages - API part 2 #7508
    - [ ] Unit tests (if necessary) replaced by ⏳ Expiring messages - API part 2 #7508

@vitormattos vitormattos added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants labels May 6, 2022
@vitormattos vitormattos added this to the 💚 Next Major (25) milestone May 6, 2022
@vitormattos vitormattos requested a review from nickvergessen May 6, 2022 01:22
@vitormattos vitormattos self-assigned this May 6, 2022
@vitormattos vitormattos marked this pull request as draft May 6, 2022 01:23
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch 2 times, most recently from dda3f0e to e0cbeef Compare May 6, 2022 01:33
nickvergessen
nickvergessen reviewed May 6, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed May 6, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed May 6, 2022
View reviewed changes
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch from e0cbeef to bf43227 Compare May 9, 2022 14:27
nickvergessen
nickvergessen reviewed May 9, 2022
View reviewed changes
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch from bf43227 to 42c8c27 Compare May 9, 2022 17:41
nickvergessen
nickvergessen reviewed May 9, 2022
View reviewed changes
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch from 42c8c27 to 2924672 Compare May 9, 2022 17:47
nickvergessen
nickvergessen reviewed May 9, 2022
View reviewed changes
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch from 2924672 to a35218c Compare May 9, 2022 19:58
@nickvergessen nickvergessen mentioned this pull request May 11, 2022
Closed
7 tasks
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch 2 times, most recently from c87c0fe to 6471c84 Compare May 13, 2022 14:46
nickvergessen
nickvergessen reviewed May 17, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed May 17, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed May 17, 2022
View reviewed changes
@vitormattos vitormattos marked this pull request as ready for review May 17, 2022 15:17
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch from f29a6ae to b8b42cd Compare May 18, 2022 12:55
nickvergessen
nickvergessen reviewed May 18, 2022
View reviewed changes
@vitormattos vitormattos force-pushed the feature/api-time-to-live branch from 6d831f5 to 7b42dfb Compare June 30, 2022 18:03
nickvergessen
nickvergessen requested changes Jul 1, 2022
View reviewed changes
@vitormattos
Fix date
26cb438 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
Add system message in chat.md
05e830f 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
Remove no more used method
21134fc 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
Replace _ by -
5a9ca1b 
Signed-off-by: Vitor Mattos <[email protected]>
nickvergessen
nickvergessen reviewed Jul 1, 2022
View reviewed changes
vitormattos and others added 3 commits July 1, 2022 10:25
@vitormattos
Rename text
af34125 
Signed-off-by: Vitor Mattos <[email protected]>
@nickvergessen
Adjust language handling in the system message
d184f0b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Rename integration test
3c16d95 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member

nickvergessen commented Jul 1, 2022

Follow ups moved to #7508

@nickvergessen
Fix event name
82a0613 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Only remove the job when expiration is "done"
30cd60e 
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
nickvergessen requested changes Jul 1, 2022
View reviewed changes
@nickvergessen nickvergessen merged commit 332352f into master Jul 1, 2022
@nickvergessen nickvergessen deleted the feature/api-time-to-live branch July 1, 2022 15:25
@nickvergessen nickvergessen mentioned this pull request Jul 1, 2022
Merged
@vitormattos vitormattos mentioned this pull request Jul 13, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@vitormattos vitormattos

Labels

3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants

Projects

💬 Talk team
Archived in project

Milestone

v15.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@vitormattos @nickvergessen