Use public API of trusted domain helper #6424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: api 🛠️
vitormattos
approved these changes
Oct 29, 2021
Contributor
vitormattos
left a comment
vitormattos
left a comment
There was a problem hiding this comment.
Will be good implement tests on method shareObjectToChat using dataset, this is a big method without good tests.
Member
Author
|
We have integration tests for it https://github.com/nextcloud/spreed/blob/master/tests/integration/features/chat/rich-object-share.feature |
Contributor
|
Because don't is a controller method, maybe will be good implement unit tests to reduce the time of integration tests. |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/6420/use-public-api
branch
from
41aaa29 to
b2b170b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6410 based on new public API from server in 23 nextcloud/server#29444
composer update christophwurst/nextcloudafter midnightFix #6420