Keep pending input message per conversation#5379
Merged
Conversation
Save the message from the current input field by conversation into the store. This makes it possible to keep the message when switching the conversation. Also fixes an issue where joining or leaving a call would clear the message due to the field being destroyed and recreated between the message list and the sidebar. Signed-off-by: Vincent Petry <[email protected]>
PVince81
commented
Mar 18, 2021
marcoambrosini
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Save the message from the current input field by conversation into the
store.
This makes it possible to keep the message when switching the
conversation.
Also fixes an issue where joining or leaving a call would clear the
message due to the field being destroyed and recreated between the
message list and the sidebar.
Related issue
Fixes #5372
Notes
Cursor position
There's a small issue: when the field is populated, the cursor appears at the beginning.
Given how complicated it is to set the cursor at the end we might want to pass on that one, considering that we'll also replace the field with a better version of it in #4333
Store module name
The store module is still called "quoteReplyStore", we could rename to "currentMessageStore" or something similar. Not sure if it's the right time now.
Tests