Skip to content

feat(chat): split own and other messages#16273

Merged
DorraJaouad merged 14 commits intomainfrom
feat/split-view-chat
Nov 25, 2025
Merged

feat(chat): split own and other messages#16273
DorraJaouad merged 14 commits intomainfrom
feat/split-view-chat

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 7, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🚧 Tasks

  • Unread marker (needs substantial change, will come in a follow up)
  • Reaction buttons and reply button in own message allegedly have different colors now (or I am color blind)
  • Own messages cannot be tracked for guests after refresh (probably not fixable)
  • Links cannot be detected from our end and they are treated as normal message (it can have the wrong grid layout)
  • New grid layout for Quote reply?

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad self-assigned this Nov 7, 2025
@DorraJaouad DorraJaouad changed the title feat(chat): split own and other messages. Add background colors feat(chat): split own and other messages Nov 7, 2025
@DorraJaouad DorraJaouad force-pushed the feat/split-view-chat branch 2 times, most recently from 1ae8687 to 2aa4f60 Compare November 8, 2025 13:54
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be a problem to support both layouts, looking at changes. Some mid-review thoughts:

  1. Settings toggle is ready, I would merge it separately and hide for now (less conflicts later). 🚧 -> new PR

  2. We should split first MessageItem and SystemMessageItem. They have nothing in common but timestamp. That would ease up both components, logic, and resources required 🚧 -> new PR

Let's finish with first 2 before proceeding.

  1. We can compute on MessagesList#prepareMessagesGroups(), whether it's a user message, and whether it's own message. We can then pass it to MessagesGroup and further and not compute anymore ❌ can wait for now

  2. We can do maybe a half of styling things simply by passing CSS classes from MessagesGroup, rather than introducing new computed ❌ can wait for now

@DorraJaouad DorraJaouad force-pushed the feat/split-view-chat branch 2 times, most recently from c909a31 to 9349124 Compare November 18, 2025 11:34
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks OK, I'm fine with follow-ups

Comment on lines 20 to 21
@mouseover="handleMouseover"
@mouseleave="handleMouseleave">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This zone should react on hover effect. Otherwise it's hard to click the buttons
Image

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is optional. Currently, we don't have a wrapper that covers the whole space.
A solution we can add a div and listen to its hovering to pass it to MessageButtonsBar

--> follow up

@click="showAllReactions = true">
<IconHeartOutline :size="15" />
</NcButton>
<span v-else class="reaction-button--thumbnail" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we reserve a place for this?

no hover hover
Image Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is reserved but in a second row, one solution is that once it reaches n reactions such that width is not available for n+1, it should wrap into n-1 reactions per row so add reaction button is not alone --> follow up

Keeping visible space in emtpy second row is not a solution 🚫

@DorraJaouad DorraJaouad merged commit f278e5f into main Nov 25, 2025
56 checks passed
@DorraJaouad DorraJaouad deleted the feat/split-view-chat branch November 25, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

↔️ Split own messages to other side

2 participants