feat(chat): split own and other messages#16273
Conversation
1ae8687 to
2aa4f60
Compare
src/components/MessagesList/MessagesGroup/Message/MessageItem.vue
Outdated
Show resolved
Hide resolved
2aa4f60 to
e8e13fc
Compare
There was a problem hiding this comment.
Should not be a problem to support both layouts, looking at changes. Some mid-review thoughts:
-
Settings toggle is ready, I would merge it separately and hide for now (less conflicts later). 🚧 -> new PR
-
We should split first MessageItem and SystemMessageItem. They have nothing in common but timestamp. That would ease up both components, logic, and resources required 🚧 -> new PR
Let's finish with first 2 before proceeding.
-
We can compute on
MessagesList#prepareMessagesGroups(), whether it's a user message, and whether it's own message. We can then pass it to MessagesGroup and further and not compute anymore ❌ can wait for now -
We can do maybe a half of styling things simply by passing CSS classes from MessagesGroup, rather than introducing new computed ❌ can wait for now
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Show resolved
Hide resolved
c909a31 to
9349124
Compare
Signed-off-by: Dorra Jaouad <[email protected]>
…een is large Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
9349124 to
e15ebcc
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/SystemMessageItem.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
e15ebcc to
fe2c8d5
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsWrapper.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsWrapper.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsWrapper.vue
Outdated
Show resolved
Hide resolved
fe2c8d5 to
34c779d
Compare
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
34c779d to
700fec7
Compare
Antreesy
left a comment
There was a problem hiding this comment.
So far looks OK, I'm fine with follow-ups
| @mouseover="handleMouseover" | ||
| @mouseleave="handleMouseleave"> |
There was a problem hiding this comment.
It is optional. Currently, we don't have a wrapper that covers the whole space.
A solution we can add a div and listen to its hovering to pass it to MessageButtonsBar
--> follow up
| @click="showAllReactions = true"> | ||
| <IconHeartOutline :size="15" /> | ||
| </NcButton> | ||
| <span v-else class="reaction-button--thumbnail" /> |
There was a problem hiding this comment.
It is reserved but in a second row, one solution is that once it reaches n reactions such that width is not available for n+1, it should wrap into n-1 reactions per row so add reaction button is not alone --> follow up
Keeping visible space in emtpy second row is not a solution 🚫
Signed-off-by: Dorra Jaouad <[email protected]>
…but edited by someone else Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
…nject and reducing the computation of isSelfActor Signed-off-by: Dorra Jaouad <[email protected]>
Signed-off-by: Dorra Jaouad <[email protected]>
700fec7 to
381c552
Compare




☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist