fix(FilesSidebar): unify chat and call views in a single app

[Antreesy]

☑️ Resolves

• ref [vue3] Fix Files Sidebar #12382
• drop legacy registerSecondaryView
• remove redundant extra app and some logic around it
• refactor callview component in sidebar

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

🚧 Tasks

• Close button breaks call view if accidentally clicked
  • temporary disabled
  • there is no case you would need to click it before leaving the call
  • Should be completely hidden, as in Public sidebar?
• Bundled size is increased for integration, Should look into optimizing initial load (see previous PR)

🏁 Checklist

• 🌏 Tested with different browsers / clients:
  • Chromium (Chrome / Edge / Opera / Brave)
  • Firefox
  • Safari
  • Talk Desktop
  • Integrations with Files sidebar and other apps
  • Not risky to browser differences / client
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible

[ShGKme]

• drop legacy registerSecondaryView

Is it legacy/deprecated API?

[Antreesy]

Is it legacy/deprecated API?

according to nextcloud/server#54337 it's a part of legacy, and with Vue3 Teleport I pretty much do not see a need for using it

[ShGKme]

according to nextcloud/server#54337 it's a part of legacy

As I understand it, only the FileInfoModel is the problematic part.

[ShGKme]

with Vue3 Teleport I pretty much do not see a need for using it

It works, but IMO it is a very indirect API. We use the internal layout of the sidebar (class names and HTML layout). Sidebar devs don't know we are teleporting something to a specific part of the sidebar

[ShGKme]

All 5 commits are fix(FilesSidebar), but I don't understand, what is being fixed, except for the disabled button during a call.

[ShGKme]

Since we have much code relying on sidebar internals like

document.querySelector('header.app-sidebar-header')

using <teleport> does not make anything more risky than it is at the moment.

Other refactorings remove some of the style overrides, which is also good.

Please, follow conventional commits.

• "a commit of the type fix patches a bug in your codebase"
  • So a commit with fix should resolve an actual problem
• We can use refactor (or chore) for refactoring
• wip: can be used for intermediate commits when the application is not in a working state, and checkout out commit breaks the app/build

it makes review easier by specifying the purpose of the change.

[Antreesy]

/backport to stable32