Skip to content

fix(textParse): use mention id to parse message parameters#14271

Merged
Antreesy merged 2 commits intomainfrom
feat/noid/expose-mention-id-frontend
Feb 21, 2025
Merged

fix(textParse): use mention id to parse message parameters#14271
Antreesy merged 2 commits intomainfrom
feat/noid/expose-mention-id-frontend

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 31, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jan 31, 2025
@Antreesy Antreesy self-assigned this Jan 31, 2025
@nickvergessen nickvergessen force-pushed the feat/noid/expose-mention-id branch 3 times, most recently from 8fba13f to a2ed72a Compare February 7, 2025 15:32
Base automatically changed from feat/noid/expose-mention-id to main February 7, 2025 15:45
@nickvergessen nickvergessen force-pushed the feat/noid/expose-mention-id-frontend branch from 85283cd to 59ff5af Compare February 7, 2025 16:02
@Antreesy Antreesy force-pushed the feat/noid/expose-mention-id-frontend branch from 59ff5af to 3ec8793 Compare February 7, 2025 19:07
@Antreesy Antreesy marked this pull request as ready for review February 7, 2025 19:07
@Antreesy Antreesy force-pushed the feat/noid/expose-mention-id-frontend branch from 3ec8793 to c69e57a Compare February 7, 2025 19:15
- wrap user mentions in double quotes

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted

@Antreesy Antreesy merged commit 28a5364 into main Feb 21, 2025
53 checks passed
@Antreesy Antreesy deleted the feat/noid/expose-mention-id-frontend branch February 21, 2025 08:09
@Antreesy
Copy link
Contributor Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants